Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move wayland event reading into the poll thread #655

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

PaideiaDilemma
Copy link
Collaborator

@PaideiaDilemma PaideiaDilemma commented Jan 21, 2025

This was done, so that we can

wl_display_prepare_read -> poll -> wl_display_read_events

That fixes synchronization issues on nvidia proprietary drivers.

Closes #572
Closes #525
Closes #419
Closes #128

This was done, so that we can

  wl_display_prepare_read -> poll -> wl_display_read_events

That fixes synchronization issues on nvidia proprietary drivers.
@PaideiaDilemma
Copy link
Collaborator Author

(mentioned the wrong issue, this does not need a wiki pr)

@PaideiaDilemma
Copy link
Collaborator Author

I tested with a 3060ti using 550.142 drivers and with a very old 3rd gen intel laptop both on Hyprland and sway

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, it works.

Worth noting almost all hypr* apps use the same poll loop, so maybe it would be worthwhile to fix this in others too? (e.g. xdph)

@vaxerski vaxerski merged commit d547d1d into hyprwm:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants