Feat/batch #49
Merged
Feat/batch #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ์ง๊ณ ๊ฒฐ๊ณผ ๋ฐํ ๊ฐ์ totalSalesAmount ํ๋ ์ถ๊ฐ - ์ง๊ณ ๊ฒฐ๊ณผ ๋ฐฐ์ด ๊ธธ์ด ๊ฒ์ฆ ๋ก์ง ์์
parseDateRange() ๋ฉ์๋๊ฐ ์ ํํ 2๊ฐ์ ๋ ์ง๋ฅผ ๋ฐํํ๋์ง ๊ฒ์ฆํ๋ ๋ก์ง์ ์ถ๊ฐํ์ฌ ์์ธ ์ํฉ์ ์ฒ๋ฆฌ
- ์ง๊ณ ์ฟผ๋ฆฌ ๊ฒฐ๊ณผ๋ฅผ Object[]์์ ProductMetricsAggregation์ผ๋ก ๋ณ๊ฒฝ - ๋ญํน ์ง๊ณ ๋ก์ง์์ DTO ๋ณํ ๋ฐ ์ ์ ๊ณ์ฐ ๋ฐฉ์ ๊ฐ์ - rankPosition ํ์ ์ long์์ int๋ก ๋ณ๊ฒฝํ์ฌ ์ผ๊ด์ฑ ๊ฐํ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Summary
๐ฌ Review Points
โ Checklist
๐ References