Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento2-react-checkout-344 The company field read the configuration … #345

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions src/ViewModel/CheckoutConfigProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
namespace Hyva\ReactCheckout\ViewModel;

use Magento\Checkout\Model\CompositeConfigProvider;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\DataObject;
use Magento\Framework\Serialize\SerializerInterface;
use Magento\Framework\View\Element\Block\ArgumentInterface;
use Magento\Framework\Locale\ResolverInterface as LocaleResolverInterface;
use Magento\Store\Model\ScopeInterface;
use Magento\Framework\Event\ManagerInterface as EventManager;

class CheckoutConfigProvider implements ArgumentInterface
Expand All @@ -31,9 +34,17 @@ class CheckoutConfigProvider implements ArgumentInterface
*/
private $currencyProvider;


/**
* @var ScopeConfigInterface
*/
private $scopeConfig;


/**
* @var EventManager
*/

private $eventManager;

/**
Expand All @@ -42,20 +53,23 @@ class CheckoutConfigProvider implements ArgumentInterface
* @param SerializerInterface $serializer
* @param LocaleResolverInterface $localeResolver
* @param CompositeConfigProvider $compositeConfigProvider
* @param CurrencyProvider $currencyProvider
* @param ScopeConfigInterface $scopeConfig
* @param EventManager $eventManager
*/
public function __construct(
SerializerInterface $serializer,
SerializerInterface $serializer,
LocaleResolverInterface $localeResolver,
CompositeConfigProvider $compositeConfigProvider,
CurrencyProvider $currencyProvider,
EventManager $eventManager
) {
CurrencyProvider $currencyProvider,
ScopeConfigInterface $scopeConfig,
EventManager $eventManager
)
{
$this->serializer = $serializer;
$this->localeResolver = $localeResolver;
$this->compositeConfigProvider = $compositeConfigProvider;
$this->currencyProvider = $currencyProvider;
$this->scopeConfig = $scopeConfig;
$this->eventManager = $eventManager;
}

Expand All @@ -78,19 +92,34 @@ public function getConfig(): string
$storeCode = $checkoutConfig['storeCode'];
$checkoutConfig['payment']['restUrlPrefix'] = "/rest/$storeCode/V1/";

$transport = new \Magento\Framework\DataObject([
$transport = new DataObject([
'checkoutConfig' => $checkoutConfig,
'output' => [
'storeCode' => $storeCode,
'payment' => $checkoutConfig['payment'],
'language' => $this->localeResolver->getLocale(),
'currency' => $this->currencyProvider->getConfig(),
'defaultCountryId' => $checkoutConfig['defaultCountryId'],
'address' => $this->getAddressConfig()
]
]);

$this->eventManager->dispatch('hyva_react_checkout_config', ['transport' => $transport]);

return $this->serializer->serialize($transport->getData('output'));
}

private function getAddressConfig()
{

return [
'company' => $this->getValue("customer/address/company_show")
];
}

public function getValue($field, $storeId = null)
{
return $this->scopeConfig->getValue($field,
ScopeInterface::SCOPE_STORE,
$storeId
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import useAddressWrapper from '../../address/hooks/useAddressWrapper';
import useBillingAddressAppContext from '../hooks/useBillingAddressAppContext';
import useFormValidateThenSubmit from '../../../hook/useFormValidateThenSubmit';
import useBillingAddressFormikContext from '../hooks/useBillingAddressFormikContext';
import RootElement from '../../../utils/rootElement';

function BillingAddressForm() {
const {
Expand All @@ -32,6 +33,7 @@ function BillingAddressForm() {
validationSchema,
setSelectedAddress,
} = useBillingAddressFormikContext();
const config = RootElement.getAddressConfig();
const { isLoggedIn } = useBillingAddressAppContext();
const { reCalculateMostRecentAddressOptions } = useAddressWrapper();
const formSubmitHandler = useFormValidateThenSubmit({
Expand Down Expand Up @@ -97,14 +99,16 @@ function BillingAddressForm() {
return (
<>
<div className="py-2">
<TextInput
required
label={__('Company')}
name={fields.company}
formikData={formikData}
onKeyDown={handleKeyDown}
placeholder={__('Company')}
/>
{config.company && (
<TextInput
required={config.company === 'req'}
label={__('Company')}
name={fields.company}
formikData={formikData}
onKeyDown={handleKeyDown}
placeholder={__('Company')}
/>
)}
<TextInput
required
name={fields.firstname}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,15 @@ import useCheckoutFormContext from '../../../hook/useCheckoutFormContext';
import BillingAddressFormContext from '../context/BillingAddressFormikContext';
import useBillingAddressAppContext from '../hooks/useBillingAddressAppContext';
import useBillingAddressCartContext from '../hooks/useBillingAddressCartContext';
import RootElement from '../../../utils/rootElement';

const requiredMessage = __('%1 is required');

const config = RootElement.getAddressConfig();
const requireCompany = config.company === 'req';

const initValidationSchema = {
company: YupString().required(requiredMessage),
company: requireCompany ? YupString().required(requiredMessage) : YupString().notRequired().nullable(),
firstname: YupString().required(requiredMessage),
lastname: YupString().required(requiredMessage),
street: YupArray().test(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import useAddressWrapper from '../../address/hooks/useAddressWrapper';
import useFormValidateThenSubmit from '../../../hook/useFormValidateThenSubmit';
import useShippingAddressAppContext from '../hooks/useShippingAddressAppContext';
import useShippingAddressFormikContext from '../hooks/useShippingAddressFormikContext';
import RootElement from "../../../utils/rootElement";

function ShippingAddressForm() {
const {
Expand All @@ -35,6 +36,7 @@ function ShippingAddressForm() {
setSelectedAddress,
isBillingFormTouched,
} = useShippingAddressFormikContext();
const config = RootElement.getAddressConfig();
const { isLoggedIn } = useShippingAddressAppContext();
const { reCalculateMostRecentAddressOptions } = useAddressWrapper();
const { countryOptions, stateOptions, hasStateOptions } = useCountryState({
Expand Down Expand Up @@ -99,14 +101,16 @@ function ShippingAddressForm() {
return (
<>
<div className="py-2">
<TextInput
required
label={__('Company')}
name={fields.company}
formikData={formikData}
onKeyDown={handleKeyDown}
placeholder={__('Company')}
/>
{config.company && (
<TextInput
required={config.company === 'req'}
label={__('Company')}
name={fields.company}
formikData={formikData}
onKeyDown={handleKeyDown}
placeholder={__('Company')}
/>
)}
<TextInput
required
name={fields.firstname}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import useCheckoutFormContext from '../../../hook/useCheckoutFormContext';
import ShippingAddressFormContext from '../context/ShippingAddressFormikContext';
import useShippingAddressAppContext from '../hooks/useShippingAddressAppContext';
import useShippingAddressCartContext from '../hooks/useShippingAddressCartContext';
import RootElement from "../../../utils/rootElement";

const defaultValues = {
company: '',
Expand All @@ -46,9 +47,10 @@ const defaultValues = {
};

const requiredMessage = __('%1 is required');

const config = RootElement.getAddressConfig();
const requireCompany = config.company === 'req';
const initValidationSchema = {
company: YupString().required(requiredMessage),
company: requireCompany ? YupString().required(requiredMessage) : YupString().notRequired().nullable(),
firstname: YupString().required(requiredMessage),
lastname: YupString().required(requiredMessage),
street: YupArray().test(
Expand Down
3 changes: 3 additions & 0 deletions src/reactapp/src/utils/rootElement.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ const RootElement = {
getCartMaskedId() {
return _get(RootElement.getCheckoutConfig(), 'cartMaskedId');
},
getAddressConfig() {
return _get(RootElement.getCheckoutConfig(), 'address') || {};
},
};

export default RootElement;