added clang-17 back to ubuntuClang pipeline #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichinii
requested changes
Oct 8, 2024
| @@ -33,7 +33,6 @@ | |||
| #else | |||
| #define RAYX_API | |||
| #endif | |||
| #pragma warning Unknown dynamic link import / export semantics. | |||
There was a problem hiding this comment.
here we could add a check for clang instead
and in CMakeLists add the define for clang like so:
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
set(COMPILE_PLATFORM RAYX_PLATFORM_CLANG)
ichinii
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforced clang
deleted pragma in core.h
added [[maybe_unused]] to counter that isn't used in the testsuite
lmk what you think.
resolves #318