Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing type issues in redbox emitted events #1005

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

jamesrichards4
Copy link
Contributor

@jamesrichards4 jamesrichards4 commented Aug 30, 2024

Context

We aren't getting input tokens sent to the django app. These are handled as dispatched events in redbox-core

Changes proposed in this pull request

Fixing some type issues in emitted events. This seems to fix the issue locally. Still not exactly clear how this caused the issue so I'll keep looking at this but this is certainly a bug

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@gecBurton gecBurton merged commit 1438a69 into main Aug 30, 2024
16 of 17 checks passed
@gecBurton gecBurton deleted the bugfix/input-tokens-not-being-counted branch August 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants