Feature/add settings to chat model #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
feature/add-settings-to-chat-model
branch
from
13975f2
to
efa0d4a
Compare
gecBurton
force-pushed
the
feature/llm-selector
branch
from
dab8fba
to
a6c20e8
Compare
gecBurton
commented
Sep 9, 2024
| user: User = self.scope.get("user", None) | ||
| user: User = self.scope.get("user") | ||
| chat_backend = data.get("llm") | ||
| temperature = data.get("temperature") |
There was a problem hiding this comment.
this will default to None, i.e. the frontend does not need to set this
KevinEtchells
approved these changes
Sep 9, 2024
KevinEtchells
added a commit
that referenced
this pull request
Sep 9, 2024
* added ai-settings to chat model * added migration test * simplified * Add LLM selector to the UI * Send selected LLM back to Django (via form submit and websocket) * Explicitly set value attributes on LLM selector, so "(default)" isn't passed on * pasing values to front end * reduced the scale of change * now updating * added temprature * added temperature to consumer --------- Co-authored-by: George Burton <g.e.c.cburton@gmail.com> Co-authored-by: Kevin Etchells <kevetchells@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I want the front end LLM sector to actually change the chat_backend, this will be "stuck" to the
ChatobjectChanges proposed in this pull request
AbstractAISettingscreated, this has all thechat_backendfield asAISettings.AISettingsinherits fromAbstractAISettings(i.e. no change)Chatnow also inherits fromAbstractAISettingsChat.chat_backendinstances are back populated with the relevantAISettings.chat_backendvaluesChat.saveis modified to populate thechat_backendfields fromchat.user.ai_settingsGuidance to review
Relevant links
Things to check