Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out /admin from Sentry #1040

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

KevinEtchells
Copy link
Contributor

@KevinEtchells KevinEtchells commented Sep 11, 2024

Context

We (probably) don't need Sentry to run on the Django Admin pages. We're getting a lot of errors around the use of jQuery and inline styles that would be a disproportionate amount of work to fix. This will also make managing "real" errors easier to discover and manage in Sentry.

Changes proposed in this pull request

  • Filter out all admin pages

Notes

  • This hasn't been properly tested yet - we can monitor this once deployed
  • Does this sound like a sensible thing to do?
  • Does the code look sensible?

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

Filter out all admin pages

Remove unused argument
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinEtchells KevinEtchells merged commit 05979a4 into main Sep 13, 2024
7 checks passed
@KevinEtchells KevinEtchells deleted the feature/sentry-filter-urls branch September 13, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants