Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/allow no meta data #1113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix/allow no meta data #1113

wants to merge 2 commits into from

Conversation

gecBurton
Copy link
Collaborator

@gecBurton gecBurton commented Oct 18, 2024

Context

As a user I do not want the file ingest to fail just because RB failed to enhance the metadata

The actual error is this:

2024-10-18 11:20:35,514 ERROR monitor: Failed 'redbox_app.worker.ingest' (Bookings_v4KpDVw.xlsx) - Some error happened in metadata extraction. Error code: 400 - {'error': {'message': "Invalid 'messages[1].content': string too long. Expected a string with maximum length 1048576, but got a string with length 1239399 instead.", 'type': 'invalid_request_error', 'param': 'messages[1].content', 'code': 'string_above_max_length'}} : Traceback (most recent call last):

So although the proposed fix doesnt address the underlying issue it will at least allow users to use their data until we find a proper solution

Changes proposed in this pull request

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

Copy link
Contributor

@KevinEtchells KevinEtchells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants