Fixes a some critical bugs in the edit screens for devices / traits w…

…hich could result in lost configuration
i8beef · Dec 31, 2022 · 25a744f · 25a744f
1 parent 2b5d34d
commit 25a744f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/HomeAutio.Mqtt.GoogleHome/Controllers/GoogleDeviceController.cs b/src/HomeAutio.Mqtt.GoogleHome/Controllers/GoogleDeviceController.cs
@@ -234,7 +234,8 @@ public IActionResult Edit([Required] string deviceId)
         [ExportModelState]
         public IActionResult Edit([Required] string deviceId, DeviceViewModel viewModel)
         {
-            if (!_deviceRepository.Contains(deviceId))
+            var existingDevice = _deviceRepository.FindById(deviceId);
+            if (existingDevice is null)
             {
                 return NotFound();
             }
@@ -276,7 +277,7 @@ public IActionResult Edit([Required] string deviceId, DeviceViewModel viewModel)
                 RoomHint = viewModel.RoomHint,
                 Name = nameInfo,
                 DeviceInfo = deviceInfo,
-                Traits = new List<DeviceTrait>()
+                Traits = existingDevice.Traits
             };
 
             // Final validation

diff --git a/src/HomeAutio.Mqtt.GoogleHome/Controllers/GoogleTraitController.cs b/src/HomeAutio.Mqtt.GoogleHome/Controllers/GoogleTraitController.cs
@@ -207,7 +207,6 @@ public IActionResult Edit([Required] string deviceId, [Required] string traitId,
             }
 
             // Set new values
-            var existingtrait = device.Traits.FirstOrDefault(x => x.Trait == traitEnumId);
             var commands = !string.IsNullOrEmpty(viewModel.Commands) ? JsonConvert.DeserializeObject<Dictionary<string, IDictionary<string, string>>>(viewModel.Commands) : null;
             var trait = new DeviceTrait
             {
@@ -224,6 +223,10 @@ public IActionResult Edit([Required] string deviceId, [Required] string traitId,
                 }
             };
 
+            // Replace trait
+            device.Traits.Remove(device.Traits.First(x => x.Trait == traitEnumId));
+            device.Traits.Add(trait);
+
             // Final validation
             foreach (var error in DeviceTraitValidator.Validate(trait))
             {