Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated aapt/aapt2 (July 2024) #3642

Closed
wants to merge 1 commit into from
Closed

Updated aapt/aapt2 (July 2024) #3642

wants to merge 1 commit into from

Conversation

iBotPeaches
Copy link
Owner

No description provided.

@iBotPeaches
Copy link
Owner Author

Changes in aapt1 to break aapt1 tests seems odd.

brut.androlib.aapt1.BuildAndDecodeTest > xmlUniformAutoTextTest FAILED
    junit.framework.AssertionFailedError at BuildAndDecodeTest.java:234

brut.androlib.aapt1.BuildAndDecodeTest > xmlAccessibilityTest FAILED
    junit.framework.AssertionFailedError at BuildAndDecodeTest.java:204

brut.androlib.aapt1.BuildAndDecodeTest > fontTest FAILED
    junit.framework.AssertionFailedError at BuildAndDecodeTest.java:355

@iBotPeaches
Copy link
Owner Author

Test is failing because

<?xml version="1.0" encoding="utf-8"?>
<TextView
  xmlns:android="http://schemas.android.com/apk/res/android" />

Expected

<?xml version="1.0" encoding="utf-8"?>
<TextView xmlns:android="http://schemas.android.com/apk/res/android" android:autoSizeTextType="uniform" />

@iBotPeaches
Copy link
Owner Author

Well it may be time to deprecate/end aapt1 support. I can still do an update for aapt2 and just let the aapt1 binaries decay.

@iBotPeaches
Copy link
Owner Author

No longer updating aapt1.

@iBotPeaches iBotPeaches deleted the updated-aapt branch July 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant