-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iBridges integration tests #34
Conversation
The uppercase Metadata keys com from this line: It was once good practice to capitalise keys, however times have changed and I think we can drop that ;) |
@chStaiger Thanks! I have moved from the python script to using pytest for our integration test. It might be a while for them to be all done. ;) |
Let me know if I can be of any help! |
So far I have added session/resources/meta tests
802781e
to
e320c14
Compare
@chStaiger I think for this PR, this is enough. Expansion of the integration tests can be done in another PR I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super useful and thanks for taking the effort converting the original integration tests into pytests! Only some minor changes and cleaning up.
|
||
def test_pam_password(session, config, irods_env): | ||
if not config["can_write_pam_pass"]: | ||
pytest.xfail("This iRods server cannot write pam passwords.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test should also work. It might have something to do with the write-rights in the docker image. I will make a note and take a look. For this PR we cna leave it like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a simple write issue though, since I'm also writing quite a few files, without problems. Maybe it's just in the root folder, or the directory is not made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!!!
from ibridges.utils.path import IrodsPath | ||
|
||
|
||
def _get_digest(obj_or_file): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!!!
See the file under docker/README.md on how to run these tests (locally).
See the file under docker/README.md on how to run these tests (locally).
Almost working, just some problems with the key that becomes uppercase for which I need @chStaiger!