Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/upgrade-storybook-v6-with-webpack5 #414

Merged

Conversation

kyoyadmoon
Copy link
Member

@kyoyadmoon kyoyadmoon commented Dec 12, 2023

Purpose

  • upgrade storybook from v5.3.2 to v6.5.12
  • use webpack5 as builder in Storybook
  • rename title of stories to fit Storybook v6 format

I suggest reviewing this PR by each individual commit.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #414 (2b8318e) into feat/upgrade-node-v20 (1ccf9e5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/upgrade-node-v20     #414   +/-   ##
======================================================
  Coverage                  88.47%   88.47%           
======================================================
  Files                        152      152           
  Lines                       1544     1544           
  Branches                     283      283           
======================================================
  Hits                        1366     1366           
  Misses                       178      178           

@kyoyadmoon kyoyadmoon marked this pull request as ready for review December 13, 2023 06:41
Base automatically changed from feat/upgrade-node-v20 to project/upgrade-react-v18 December 18, 2023 10:08
@kyoyadmoon kyoyadmoon merged commit 4dc2beb into project/upgrade-react-v18 Dec 18, 2023
8 checks passed
@kyoyadmoon kyoyadmoon deleted the docs/upgrade-storybook-v6-with-webpack5 branch December 18, 2023 10:25
@zhusee2 zhusee2 added this to the v7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants