Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to streamlog instead of Marlin_LIBRARIES #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmcarcell
Copy link

BEGINRELEASENOTES

  • Link to streamlog instead of Marlin_LIBRARIES.

ENDRELEASENOTES

Uncovered by iLCSoft/Marlin#56, only streamlog is needed by KiTrack.

Comment on lines 26 to 27
FIND_PACKAGE( Marlin 1.0 REQUIRED ) # minimum required Marlin version
INCLUDE_DIRECTORIES( ${Marlin_INCLUDE_DIRS} )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to find Marlin if we only want streamlog?

Copy link
Author

@jmcarcell jmcarcell Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some includes that need Marlin:
https://github.com/iLCSoft/KiTrack/blob/master/include/KiTrack/SubsetSimple.h#L6 so it should be needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants