Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ilib-loctool-tap-i18n) Always output plural category many for Polish and Russian targets #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wadimw
Copy link
Contributor

@wadimw wadimw commented Feb 17, 2025

Added required plural categories for target plurals output by this plugin. If translation for those categories is not provided, they will always fall back to the translation for other.

Hardcoded required category many for Polish and Russian.

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: d20d079

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ilib-loctool-tap-i18n Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Jest Code Coverage

Code Coverage for changed files • (0%) 
File% Stmts% Branch% Funcs% LinesUncovered Line #s
report-only-changed-files is enabled. No files were changed in this commit :)
Title Lines Statements Branches Functions
loctool Coverage: 81%
81.53% (6638/8141) 74.29% (3370/4536) 72.78% (757/1040)
Title Tests Skipped Failures Errors Time
loctool 2296 81 💤 0 ❌ 0 🔥 46.785s ⏱️

@wadimw
Copy link
Contributor Author

wadimw commented Feb 17, 2025

@ehoogerbeets I chose to implement this as automatically adding category many next to other rather than replacing it because:

  1. it's easier to implement
  2. typically, plurals require other to be present anyway
  3. if the version of i18next we need to support does not support fallback to other, in the worst case this additional variant is simply ignored

@wadimw wadimw force-pushed the tap-required-categories branch from cc46d48 to d20d079 Compare February 17, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant