-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of MSP RC stats and info messages #10451
Merged
Merged
+232
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial, basic implementation. This can be expanded in the future to deal with multiple sublinks etc.
- Add RSSI - Allow extended versions of future MSP2_COMMON_SET_MSP_RC_LINK_STATS and MSP2_COMMON_SET_MSP_RC_INFO still work with older (from now) INAV versions. Except for the new data.
- Added new RX operands to programming framework - Added new OSD elements - Updated CRSF elements that are no longer exclusive to CRSF
- Force band and mode to uppercase - Fix bug with band and mode not finalising the string output to the OSD - Changed RSSI dBm and SNR display outputs slightly. So that the OSD is more consistent - Show mW symbol for power elements when no data is present. Again, more consistency and doesn't make people wonder why the elements are not showing up.
mmosca
reviewed
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is to kick off the changes asked for in #10363
Requires configurator iNavFlight/inav-configurator#2230
We are adding two new common MSP V2 messages:
MSP2_COMMON_SET_MSP_RC_LINK_STATS
0x100DMSP2_COMMON_SET_MSP_RC_INFO
0x100EThey are called to update the firmware of changes on the MSP RC receiver/transceiver.
MSP2_COMMON_SET_MSP_RC_LINK_STATS
is sent with every packet andMSP2_COMMON_SET_MSP_RC_INFO
is sent periodically and when changes are made. Payload size checking has been set so that the payload must at least meet the current defined payload. Future updates to payload would need to be accounted for in updated versions of INAV. But at least, this base data will still be able to be processed.MSP2_COMMON_SET_MSP_RC_LINK_STATS
MSP2_COMMON_SET_MSP_RC_INFO
Changes
Limitations of current implementation
Due to time constraints. This initial implementation is not a full implementation.