initial changes to support transforms without changesets

iTwin · Dec 10, 2024 · 8d7c6b7 · 8d7c6b7
1 parent 4383d00
commit 8d7c6b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/transformer/src/IModelExporter.ts b/packages/transformer/src/IModelExporter.ts
@@ -454,7 +454,7 @@ export class IModelExporter {
     await this.initialize(initOpts);
     // _sourceDbChanges are initialized in this.initialize
     nodeAssert(
-      this._sourceDbChanges !== undefined,
+      this._sourceDbChanges !== undefined, // TODO: Should this say that sourceDbChanges must not be empty?
       "sourceDbChanges must be initialized."
     );
 
@@ -586,7 +586,7 @@ export class IModelExporter {
   public async exportCodeSpecByName(codeSpecName: string): Promise<void> {
     const codeSpec: CodeSpec = this.sourceDb.codeSpecs.getByName(codeSpecName);
     let isUpdate: boolean | undefined;
-    if (undefined !== this._sourceDbChanges) {
+    if (this._sourceDbChanges !== undefined && !this._sourceDbChanges.isEmpty) {
       // is changeset information available?
       if (this._sourceDbChanges.codeSpec.insertIds.has(codeSpec.id)) {
         isUpdate = false;
@@ -686,7 +686,7 @@ export class IModelExporter {
   /** Export the model (the container only) from the source iModel. */
   private async exportModelContainer(model: Model): Promise<void> {
     let isUpdate: boolean | undefined;
-    if (undefined !== this._sourceDbChanges) {
+    if (this._sourceDbChanges !== undefined && !this._sourceDbChanges.isEmpty) {
       // is changeset information available?
       if (this._sourceDbChanges.model.insertIds.has(model.id)) {
         isUpdate = false;
@@ -725,7 +725,7 @@ export class IModelExporter {
       );
       return;
     }
-    if (undefined !== this._sourceDbChanges) {
+    if (this._sourceDbChanges !== undefined && !this._sourceDbChanges.isEmpty) {
       // is changeset information available?
       if (
         !this._sourceDbChanges.model.insertIds.has(modelId) &&
@@ -956,7 +956,7 @@ export class IModelExporter {
       return;
     }
     let isUpdate: boolean | undefined;
-    if (undefined !== this._sourceDbChanges) {
+    if (this._sourceDbChanges !== undefined && !this._sourceDbChanges.isEmpty) {
       // is changeset information available?
       if (this._sourceDbChanges.relationship.insertIds.has(relInstanceId)) {
         isUpdate = false;
@@ -1399,7 +1399,7 @@ export class ChangedInstanceIds {
           : undefined;
 
     // TODO: should we do this in this PR?
-    if (csFileProps === undefined) return undefined; // return new ChangedInstanceIds(opts.iModel); // i think we probably need to return sourcedbchanges here even if empty. that sets us up for a transform with nothing
+    if (csFileProps === undefined) return new ChangedInstanceIds(opts.iModel); // i think we probably need to return sourcedbchanges here even if empty. that sets us up for a transform with nothing
 
     const changedInstanceIds = new ChangedInstanceIds(opts.iModel);
 

diff --git a/packages/transformer/src/IModelTransformer.ts b/packages/transformer/src/IModelTransformer.ts
@@ -2790,6 +2790,7 @@ export class IModelTransformer extends IModelExportHandler {
         this.context.remapElement(sourceElementId, targetElementId);
       }
     );
+    // hmm if we do transforms without changesets this may be a problem for hasElementChangedCache? and maybe others
     if (this._csFileProps === undefined || this._csFileProps.length === 0)
       return;
     const hasElementChangedCache = new Set<string>();