switch to hasChanges, fix bad condition check AGAIN!!

iTwin · Jan 10, 2025 · a5c2c76 · a5c2c76
1 parent f026eaf
commit a5c2c76
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/packages/transformer/src/IModelExporter.ts b/packages/transformer/src/IModelExporter.ts
@@ -1177,14 +1177,14 @@ export class ChangedInstanceIds {
     return this._hasCustomRelationshipChanges;
   }
 
-  public get isEmpty(): boolean {
+  public get hasChanges(): boolean {
     return (
-      this.codeSpec.isEmpty &&
-      this.model.isEmpty &&
-      this.element.isEmpty &&
-      this.aspect.isEmpty &&
-      this.relationship.isEmpty &&
-      this.font.isEmpty
+      !this.codeSpec.isEmpty ||
+      !this.model.isEmpty ||
+      !this.element.isEmpty ||
+      !this.aspect.isEmpty ||
+      !this.relationship.isEmpty ||
+      !this.font.isEmpty
     );
   }
 

diff --git a/packages/transformer/src/IModelTransformer.ts b/packages/transformer/src/IModelTransformer.ts
@@ -2845,7 +2845,7 @@ export class IModelTransformer extends IModelExportHandler {
     if (this._csFileProps === undefined || this._csFileProps.length === 0) {
       if (
         this.exporter.sourceDbChanges === undefined ||
-        this.exporter.sourceDbChanges.isEmpty
+        !this.exporter.sourceDbChanges.hasChanges
       )
         return;
       // our sourcedbChanges aren't empty (probably due to someone adding custom changes), change our sourceChangeDataState to has-changes
@@ -3021,7 +3021,8 @@ export class IModelTransformer extends IModelExportHandler {
     const notConnectedModel = this.sourceDb.iTwinId === undefined;
     const noChanges =
       this.synchronizationVersion.index === this.sourceDb.changeset.index &&
-      this.exporter.sourceDbChanges?.isEmpty;
+      (this.exporter.sourceDbChanges === undefined ||
+        !this.exporter.sourceDbChanges.hasChanges);
     if (notConnectedModel || noChanges) return;
 
     const sourceIdOfRelationshipInTarget = await this.getTargetIdFromSourceId(
@@ -3089,7 +3090,8 @@ export class IModelTransformer extends IModelExportHandler {
     const notConnectedModel = this.sourceDb.iTwinId === undefined;
     const noChanges =
       this.synchronizationVersion.index === this.sourceDb.changeset.index &&
-      this.exporter.sourceDbChanges?.isEmpty;
+      (this.exporter.sourceDbChanges === undefined ||
+        !this.exporter.sourceDbChanges.hasChanges);
     if (notConnectedModel || noChanges) return;
 
     let targetId = await this.getTargetIdFromSourceId(