Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented missing methods in BigMap #142

Closed
wants to merge 17 commits into from
Closed

Implemented missing methods in BigMap #142

wants to merge 17 commits into from

Conversation

JulijaRamoskiene
Copy link
Contributor

@JulijaRamoskiene JulijaRamoskiene commented Jan 22, 2024 •
edited
Loading

Closes #134

  • Changed BigMap to implement Map instead of extending it. Implemented missing methods.
  • Added BigMap tests.
  • Added iModelTransformer test to verify that unresolved references are logged correctly. Moved logger initialization logic to beforeEach(), as it is reconfigured in new test case.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

MichaelBelousov
MichaelBelousov reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@MichaelBelousov MichaelBelousov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great BigMap tests!
Can you add a test proving that #134 is fixed?

packages/transformer/src/BigMap.ts Outdated Show resolved Hide resolved
packages/transformer/src/BigMap.ts Outdated Show resolved Hide resolved
packages/transformer/src/BigMap.ts Outdated Show resolved Hide resolved
packages/transformer/src/test/standalone/BigMap.test.ts Outdated Show resolved Hide resolved
packages/transformer/src/test/standalone/BigMap.test.ts Outdated Show resolved Hide resolved
@JulijaRamoskiene
Copy link
Contributor Author

Great BigMap tests! Can you add a test proving that #134 is fixed?

Added "should log unresolved references" test case

@JulijaRamoskiene
Copy link
Contributor Author

Recreated PR (fork PR's have build issues) :#144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick4598 nick4598 nick4598 left review comments

@MichaelBelousov MichaelBelousov MichaelBelousov left review comments

@ColinKerr ColinKerr Awaiting requested review from ColinKerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IModelTransformer is not handling unresolved elements in finalizeTransformation()
4 participants
@JulijaRamoskiene @CLAassistant @MichaelBelousov @nick4598