Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.3.3 support #143

Merged
merged 5 commits into from
Jan 22, 2024
Merged

4.3.3 support #143

merged 5 commits into from
Jan 22, 2024

Conversation

nick4598
Copy link
Collaborator

@nick4598 nick4598 commented Jan 22, 2024 •
edited by MichaelBelousov
Loading

  • Ignore fed guids on always present element ids when comparing imodels in tests
  • closeIModel() + closeFile()
  • script to only update locked itwin deps
  • bump locked itwin dev deps

@nick4598 nick4598 changed the title allow the alwaysPresentElementIds to have different fed guids when asserting identity transform 4.3.3 support Jan 22, 2024
@MichaelBelousov MichaelBelousov merged commit 625df9f into main Jan 22, 2024
16 checks passed
@MichaelBelousov MichaelBelousov deleted the nick/ignorefedguidsalwayspresentelementids branch January 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBelousov MichaelBelousov MichaelBelousov approved these changes

@ColinKerr ColinKerr Awaiting requested review from ColinKerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick4598 @MichaelBelousov