Make processALl and processChanges private, expose a public process function and let people pass isSync to constructor of imodeltransformer #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and public process. Still implicitly calling initialize though.
…ges considerably whether isSync is true or not?
nick4598
commented
Jul 10, 2024
JulijaRamoskiene
requested changes
Jul 11, 2024
JulijaRamoskiene
requested changes
Jul 12, 2024
|
|
nick4598
commented
Aug 12, 2024
packages/transformer/src/test/standalone/IModelTransformerHub.test.ts
Outdated
Show resolved
Hide resolved
packages/transformer/src/test/standalone/IModelTransformerHub.test.ts
Outdated
Show resolved
Hide resolved
JulijaRamoskiene
requested changes
Aug 16, 2024
JulijaRamoskiene
requested changes
Aug 16, 2024
JulijaRamoskiene
approved these changes
Aug 26, 2024
nick4598
added a commit
that referenced
this pull request
Nov 20, 2024
…unction and let people pass isSync to constructor of imodeltransformer (#190) Co-authored-by: Daniel Erbynn <Daniel.Erbynn@bentley.com> Co-authored-by: derbynn <44528840+derbynn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.