Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer track partially commited element references #206

Merged
merged 10 commits into from
Oct 1, 2024
6 changes: 0 additions & 6 deletions packages/transformer/src/IModelExporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,6 @@ export abstract class IModelExportHandler {
return true;
}

/** Called when element is skipped instead of exported. */
public onSkipElement(_elementId: Id64String): void {}
nick4598 marked this conversation as resolved.
Show resolved Hide resolved

/** Called when an element should be exported.
* @param element The element to export
* @param isUpdate If defined, then `true` indicates an UPDATE operation while `false` indicates an INSERT operation. If not defined, then INSERT vs. UPDATE is not known.
Expand Down Expand Up @@ -836,7 +833,6 @@ export class IModelExporter {
// Return early if the elementId is already in the excludedElementIds, that way we don't need to load the element from the db.
if (this._excludedElementIds.has(elementId)) {
Logger.logInfo(loggerCategory, `Excluded element ${elementId} by Id`);
this.handler.onSkipElement(elementId);
return;
}

Expand Down Expand Up @@ -867,8 +863,6 @@ export class IModelExporter {
elementId
);
return this.exportChildElements(elementId);
} else {
this.handler.onSkipElement(element.id);
}
}

Expand Down
Loading
Loading