Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer track partially commited element references #206

Merged
merged 10 commits into from
Oct 1, 2024
Merged

No longer track partially commited element references #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c414e41
no longer track partially commited element references
ViliusRuskys Sep 6, 2024
2bf48d9
remove unused type
ViliusRuskys Sep 9, 2024
cbd44d5
Merge remote-tracking branch 'origin/main' into partial-element-fix
ViliusRuskys Sep 9, 2024
0f2e26a
Change files
ViliusRuskys Sep 10, 2024
40f90a7
update change type
ViliusRuskys Sep 10, 2024
817a154
fixed error messages, removed TODO comments
ViliusRuskys Sep 23, 2024
568dc49
fix log messages
ViliusRuskys Sep 24, 2024
1eb8df8
Merge branch 'main' into partial-element-fix
nick4598 Sep 26, 2024
b18bc84
bring back the onSkipElement method
ViliusRuskys Oct 1, 2024
f71816f
Merge branch 'partial-element-fix' of https://github.com/iTwin/imodel…
ViliusRuskys Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@itwin-imodel-transformer-a82348d2-2c15-45c2-9a7c-48d607ef8fce.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "no longer track partially commited element references",
"packageName": "@itwin/imodel-transformer",
"email": "36619139+ViliusRuskys@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/transformer/src/IModelExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ export abstract class IModelExportHandler {
return true;
}

/** Called when element is skipped instead of exported. */
/** Called when element is skipped instead of exported.
* @note When an element is skipped, exporter will not export any of its child elements. Because of this, [[onSkipElement]] will not be invoked for any children of a "skipped" element.
*/
public onSkipElement(_elementId: Id64String): void {}
nick4598 marked this conversation as resolved.
Show resolved Hide resolved

/** Called when an element should be exported.
Expand Down
Loading
Loading