Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace nativedb extractChangedInstanceIdsFromChangeSets #213

Merged
merged 1 commit into from
Oct 10, 2024
Merged

replace nativedb extractChangedInstanceIdsFromChangeSets #213

merged 1 commit into from
Oct 10, 2024

Conversation

derbynn
Copy link
Contributor

@derbynn derbynn commented Oct 10, 2024

  • In an effort to replace internal apis that are currently deprecated and will be removed in itwin js 5.0 release, we found an alternative implementation for nativeDb.extractChangedInstanceIdsFromChangeSets.
  • ChangedInstanceIds.initialize extracts the changed instance ids and returns it.
  • This is used in our IModelTransformerHub tests

@derbynn derbynn marked this pull request as ready for review October 10, 2024 20:26
@derbynn derbynn requested review from a team as code owners October 10, 2024 20:26
@derbynn derbynn merged commit 019ac25 into main Oct 10, 2024
13 checks passed
@derbynn derbynn deleted the daniel/replace-internal-apis branch October 10, 2024 20:45
@derbynn derbynn mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick4598 nick4598 nick4598 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derbynn @nick4598