Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nativedb schemaToXmlString #217

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Replace nativedb schemaToXmlString #217

merged 3 commits into from
Oct 15, 2024

Conversation

derbynn
Copy link
Contributor

@derbynn derbynn commented Oct 15, 2024 •
edited
Loading

  • Add SchemaTestUtils class that with schemaToXmlString method
  • To convert schema to an xml string I added @itwin/ecschema-locaters as they have helper to do this
  • In an effort to replace internal apis that are currently deprecated and will be removed in itwin js 5.0 release, we will replace nativeDb.schemaToXmlString with SchemaTestUtils.schemaToXmlString

@derbynn derbynn marked this pull request as ready for review October 15, 2024 17:08
@derbynn derbynn requested review from a team as code owners October 15, 2024 17:08
@derbynn derbynn merged commit b08a684 into main Oct 15, 2024
13 checks passed
@derbynn derbynn deleted the daniel/replace-schemaToXmlString branch October 15, 2024 17:14
@derbynn derbynn mentioned this pull request Oct 15, 2024
Open
@derbynn derbynn changed the title Replace native schemaToXmlString Replace nativeDb schemaToXmlString Oct 15, 2024
@derbynn derbynn changed the title Replace nativeDb schemaToXmlString Replace nativedb schemaToXmlString Oct 15, 2024
nick4598 pushed a commit that referenced this pull request Nov 20, 2024
@derbynn @nick4598
Replace native schemaToXmlString (#217)
5b31e68 
- Add SchemaTestUtils class that with schemaToXmlString method
- To convert schema to an xml string I added @itwin/ecschema-locaters as they have helper to do this
- In an effort to replace internal apis that are currently deprecated and will be removed in itwin js 5.0 release, we will replace `nativeDb.schemaToXmlString` with `SchemaTestUtils.schemaToXmlString`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick4598 nick4598 nick4598 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derbynn @nick4598