docs: clarify getDerivedClasses behavior regarding unloaded referencing schemas (#8047) #8795
+109
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmitKmishra
requested review from
a team,
AureMonke,
ColinKerr,
StefanApfel-Bentley and
rschili
as code owners
|
|
rschili
reviewed
Nov 22, 2025
| @@ -0,0 +1,90 @@ | |||
| import { assert } from "chai"; | |||
Contributor
There was a problem hiding this comment.
Thanks for contributing!
This test seems alright, but we usually don't follow the pattern of putting tests for one issue into a separate file.
Putting this into the ecdb tests is also not the best fit for this.
We do have a very similar existing SchemaContext embedded in IModelDb.
So either this should be a high level test using IModelDb, in which case core/backend/src/test/schema/IModelSchemaContext.test.ts is a good location.
Or if we just want to confirm the ecschema-metadata package behavior, which is more of a unit test, core/ecschema-metadata/src/test/Context/SchemaContext.test.ts is the place to put it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8047.
Analysis:
getDerivedClassesrelies on the currentSchemaContextto identify subclasses. SinceSchemaContextdoes not maintain a reverse-index of all possible external schemas that might reference a base class, it is architecturally impossible for this method to return classes from unloaded schemas without a global pre-scan.Changes:
core/backenddemonstrating thatgetDerivedClassesreturns empty until the referencing schema is explicitly loaded.getDerivedClassesincore/ecschema-metadatato explicitly warn users that referencing schemas must be loaded into the context to be discovered.This resolves the ambiguity noted by the reporter.