Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup for ITMApplication #80

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

tcobbs-bentley
Copy link
Member

@tcobbs-bentley tcobbs-bentley commented Feb 27, 2024

Also contains updates to other classes that are a direct result of ITMApplication changes.

Notes:

  1. The ITMMessenger changes were done to avoid potential issues that previously required the suppression of LeakingThis. Changing logger to observable and updating the messenger when the logger changes maintains the old functionality.
  2. The ITMNativeUI changes were also done to avoid having to suppress LeakingThis, and to avoid running into problems due to that suppression.
  3. The ITMWebViewLogger change was due to fixes added to ITMApplication to detach the logger when appropriate.

Also contains updates to other classes that are a direct result of `ITMApplication` changes.
@tcobbs-bentley tcobbs-bentley merged commit 07a982e into main Feb 28, 2024
4 checks passed
@tcobbs-bentley tcobbs-bentley deleted the travis/itmapplication-cleanup branch February 28, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants