Feature/feg 526 #32
Open
Feature/feg 526 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for iamdesign ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
natwalker-iap
requested changes
Oct 2, 2025
There was a problem hiding this comment.
@jonathanoriordan-iap this is looking good! Just a few comments about re-using components where you can.
natwalker-iap
approved these changes
Oct 9, 2025
| </HeroSection> | ||
| <div class="make-it visualtest colour-block bg-info gradient-primary gradient-direction-angle"> | ||
| <div> | ||
| <img class="intuitive-card" src="assets/images/illustrations/Intuitive.png" alt="intuitive-image"> |
There was a problem hiding this comment.
I would suggest using a single class for all of these since they share the same CSS. Something like .principle-card
| </div> | ||
|
|
||
| <div> | ||
| <img class="empowering-card" src="assets/images/illustrations/Empowering.png" alt="empowering-image"> |
There was a problem hiding this comment.
Alt text should describe what's happening in the image or perhaps in this case, include the text from the image e.g., "Make it intuitive'
|
|
||
| <TextMediaSection :media-first="true"> | ||
| <template #text> | ||
| <div class="empowering-text"> |
There was a problem hiding this comment.
instead of setting the order on this div, you should be able to change the :media-first prop to false on line 52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates our-principles figma design on ticket FEG-526
Page can be viewed at-https://deploy-preview-32--iamdesign.netlify.app/articles/principles