Fix default sensor variables in homio_room template#30
Open
isaacrushworth2002 wants to merge 1 commit intoiamtherufus:mainfrom
Open
Fix default sensor variables in homio_room template#30isaacrushworth2002 wants to merge 1 commit intoiamtherufus:mainfrom
isaacrushworth2002 wants to merge 1 commit intoiamtherufus:mainfrom
Conversation
The default values for motion_sensor, temp_sensor, and humid_sensor were set to the literal strings "variables.motion_sensor", "variables.temp_sensor", and "variables.humid_sensor" respectively. When a user doesn't provide these sensor variables (e.g. setting show_temp: false without a temp_sensor), the JavaScript template checks like `if (!variables.motion_sensor)` evaluate as truthy because they contain non-empty strings. This then causes the template to attempt `states["variables.motion_sensor"]` which throws: ButtonCardJSTemplateError: Cannot read properties of undefined (reading 'state') Changed the defaults to empty strings so the falsy checks work correctly when sensors aren't provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default values for motion_sensor, temp_sensor, and humid_sensor were set to the literal strings "variables.motion_sensor", "variables.temp_sensor", and "variables.humid_sensor" respectively.
When a user doesn't provide these sensor variables (e.g. setting show_temp: false without a temp_sensor), the JavaScript template checks like
if (!variables.motion_sensor)evaluate as truthy because they contain non-empty strings. This then causes the template to attemptstates["variables.motion_sensor"]which throws:ButtonCardJSTemplateError: Cannot read properties of undefined (reading 'state')
Changed the defaults to empty strings so the falsy checks work correctly when sensors aren't provided.