Compile improvements #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new step was added to the msbuild GitHub Actions workflow to print the clang-cl compiler version. This helps with debugging and verifying the build environment.
Remove all Win32 and Debug configurations from the solution and project files, leaving only the Release|x64 configuration. This simplifies the build setup to target only 64-bit Release builds.
Changed 'teclado.h' to 'Teclado.h' in both header and source files to match the correct case. Also fixed the method declaration for askToEnable by removing redundant scope resolution in AdvanceMode.h.
Enabled SDL checks and treat warnings as errors in the Release configuration. Removed redundant IncludePath and empty custom/pre-build steps for a cleaner project file.
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on cleaning up the build configuration and improving compilation strictness by enabling better compiler checks and removing unused build configurations.
- Enables stricter compilation settings (SDLCheck and TreatWarningAsError) for the Release|x64 configuration
- Removes unused Debug and Win32 build configurations, streamlining the project to only support Release|x64
- Fixes include file case sensitivity and removes redundant class qualifiers
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/AdvanceMode.cpp | Fixed include directive capitalization for case-sensitive file systems (teclado.h → Teclado.h) |
| include/AdvanceMode.h | Fixed include capitalization and removed redundant class qualifier from method declaration |
| RealViewOn.vcxproj | Removed unused Win32 and Debug configurations, enabled SDL checks and treat warnings as errors, fixed post-build event path, cleaned up empty XML elements |
| RealViewOn.sln | Removed unused Debug and Win32 platform configurations from solution file |
| .github/workflows/msbuild.yml | Added step to print clang-cl version for build diagnostics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation cleaning + minor fix