Skip to content

Comments

Mask API key in shelved.patch#1

Open
NickEinstein1 wants to merge 1 commit intoianktoo:developerfrom
Mind-Wrap-X:developer
Open

Mask API key in shelved.patch#1
NickEinstein1 wants to merge 1 commit intoianktoo:developerfrom
Mind-Wrap-X:developer

Conversation

@NickEinstein1
Copy link

Updated API key in shelved patch to a masked version.

Updated API key in shelved patch to a masked version.
@NickEinstein1
Copy link
Author

API KEY Update.

Copy link
Owner

@ianktoo ianktoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove commit history?

@ianktoo ianktoo assigned ianktoo and NickEinstein1 and unassigned ianktoo Nov 18, 2025
@ianktoo
Copy link
Owner

ianktoo commented Nov 18, 2025

@NickEinstein1 , you need to recreate the branch as an orphan. Exposing your API key left some crumbs in github history.

  1. create a new branch as an orphan
  2. switch to that branch
  3. delete previous branch
  4. rename the new branch to the original name
  5. push and create a pull request!

@NickEinstein1
Copy link
Author

@NickEinstein1 , you need to recreate the branch as an orphan. Exposing your API key left some crumbs in github history.

  1. create a new branch as an orphan
  2. switch to that branch
  3. delete previous branch
  4. rename the new branch to the original name
  5. push and create a pull request!

Sure did just that but the key crumbs left there are just a simulation of d-types, alphanumeric composition of the key is much short but look at what we have actual crumbs that do not add up !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants