forked from atsamd-rs/atsamd
-
Notifications
You must be signed in to change notification settings - Fork 0
example: Adding async DMAC #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
supersimple33
wants to merge
15
commits into
ianrrees:manage
Choose a base branch
from
supersimple33:example/gc4-blinky
base: manage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a few TODOs before this can really be put to use:
* Tool needs to populate examples section of BSP Cargo.toml
* Move examples from BSPs to the examples directory
* Handle support files for examples
* Think about CI and whether we want to leave the BSP example dir
populated
This avoids issues with some specific examples that use macro
definitions containing `{{`, which handlebars uses as a delimiter.
Note this does change the behaviour of feather_m4 slightly - the LED now blinks faster. Since we're likely going to want variations for different HAL versions, chip families, bootloaders; maybe we need to add a renaming functionality. For example, we might have a generic-m4-blinky_basic.rs and a generic-m0-blinky_basic.rs which get distributed as boards/.../examples/blinky_basic.rs
Did this due to dependency clash, looks like updating nom will be the easiest way forward but don't have time now.
Author
|
I added feather m4 but I can't test any of this pr on device rn. |
4424471 to
8d83432
Compare
dd19a6a to
1c718a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added it for the metro_m4 and gc_m4 as of right now but I'm gonna search for who else should be included.