IBX-8429: Respect field groups' order based on field definitions' ord…

…er (#1295) * IBX-8429: Respect field groups' order based on field definitions' order * IBX-8429: Name fallback * IBX-8429: Added test coverage * IBX-8429: Simplified code * IBX-8429: Rollback conditional * IBX-8429: Simplified code
ibexa · Aug 7, 2024 · 7e6bb94 · 7e6bb94
1 parent 0e8c9f3
commit 7e6bb94
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 17 deletions.
diff --git a/src/lib/Util/FieldDefinitionGroupsUtil.php b/src/lib/Util/FieldDefinitionGroupsUtil.php
@@ -30,22 +30,17 @@ public function __construct(FieldsGroupsList $fieldsGroupsListHelper)
      */
     public function groupFieldDefinitions(iterable $fieldDefinitions): array
     {
-        $fieldDefinitionsByGroup = [];
-        foreach ($this->fieldsGroupsListHelper->getGroups() as $groupId => $groupName) {
-            $fieldDefinitionsByGroup[$groupId] = [
-                'name' => $groupName,
-                'fieldDefinitions' => [],
-            ];
-        }
+        $fieldsGroups = $this->fieldsGroupsListHelper->getGroups();
+        $defaultGroup = $this->fieldsGroupsListHelper->getDefaultGroup();
 
+        $fieldDefinitionsByGroup = [];
         foreach ($fieldDefinitions as $fieldDefinition) {
-            $groupId = $fieldDefinition->fieldGroup;
-            if (!$groupId) {
-                $groupId = $this->fieldsGroupsListHelper->getDefaultGroup();
-            }
+            $groupId = $fieldDefinition->fieldGroup ?: $defaultGroup;
 
+            $fieldDefinitionsByGroup[$groupId]['name'] = $fieldDefinitionsByGroup[$groupId]['name']
+                ?? $fieldsGroups[$groupId]
+                ?? $defaultGroup;
             $fieldDefinitionsByGroup[$groupId]['fieldDefinitions'][] = $fieldDefinition;
-            $fieldDefinitionsByGroup[$groupId]['name'] = $fieldDefinitionsByGroup[$groupId]['name'] ?? $groupId;
         }
 
         return $fieldDefinitionsByGroup;

diff --git a/tests/lib/Util/FieldDefinitionGroupsUtilTest.php b/tests/lib/Util/FieldDefinitionGroupsUtilTest.php
@@ -17,21 +17,27 @@ class FieldDefinitionGroupsUtilTest extends TestCase
     public function testGroupFieldDefinitions()
     {
         $randomGroupFieldDefinition = new FieldDefinition(['fieldGroup' => 'random']);
+        $testGroupFieldDefinition = new FieldDefinition(['fieldGroup' => 'test']);
         $defaultGroupFieldDefinition = new FieldDefinition();
 
         $fieldDefinitions = [
             $randomGroupFieldDefinition,
+            $testGroupFieldDefinition,
             $defaultGroupFieldDefinition,
         ];
         $groupedFieldDefinitions = [
-            'content' => [
-                'name' => 'Content',
-                'fieldDefinitions' => [$defaultGroupFieldDefinition],
-            ],
             'random' => [
                 'name' => 'Random',
                 'fieldDefinitions' => [$randomGroupFieldDefinition],
             ],
+            'test' => [
+                'name' => 'Test',
+                'fieldDefinitions' => [$testGroupFieldDefinition],
+            ],
+            'content' => [
+                'name' => 'Content',
+                'fieldDefinitions' => [$defaultGroupFieldDefinition],
+            ],
         ];
 
         $fieldsGroupsListHelper = $this->getMockBuilder(FieldsGroupsList::class)->getMock();
@@ -40,10 +46,11 @@ public function testGroupFieldDefinitions()
             ->willReturn('content');
         $fieldsGroupsListHelper
             ->method('getGroups')
-            ->willReturn(['random' => 'Random', 'content' => 'Content']);
+            ->willReturn(['another' => 'Another', 'test' => 'Test', 'random' => 'Random', 'content' => 'Content']);
 
         $util = new FieldDefinitionGroupsUtil($fieldsGroupsListHelper);
 
+        $this->assertSame($groupedFieldDefinitions, $util->groupFieldDefinitions($fieldDefinitions));
         $this->assertEquals($groupedFieldDefinitions, $util->groupFieldDefinitions($fieldDefinitions));
     }
 }