IBX-7895: Added possibility to change create content button label #1200
Conversation
src/lib/Specification/ContentType/ContentTypeIsDashboardContainer.php
Outdated
Show resolved
Hide resolved
| use Ibexa\AdminUi\Specification\AbstractSpecification; | ||
| use Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType; | ||
|
|
||
| class ContentTypeIsDashboardContainer extends AbstractSpecification |
There was a problem hiding this comment.
ibexa/admin-ui must not have any knowledge about the ibexa/dashboard
There was a problem hiding this comment.
This is not resolved, you are still checking for dashboard.container_content_type_identifier parameter. What you need here is an extension point and contain that whole logic inside dashboard package.
|
| public function createLabel(ContentType $contentType): string; | ||
| } | ||
|
|
||
| class_alias(ContentRightSidebarLabelFactoryInterface::class, 'EzSystems\EzPlatformAdminUi\Menu\ContentRightSidebarLabelFactoryInterface'); |
There was a problem hiding this comment.
Those are not needed in new code.
| public const CREATE_USER = 'sidebar_right.create_user'; | ||
|
|
||
| /** @var \Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface */ | ||
| private $configResolver; |
There was a problem hiding this comment.
| private $configResolver; | |
| private ConfigResolverInterface $configResolver; |
| @@ -10,6 +10,12 @@ services: | |||
|
|
|||
| Ibexa\AdminUi\Menu\MenuItemFactory: ~ | |||
|
|
|||
| # | |||
| # Right Sidebar Label Factory | |||
| # | |||
There was a problem hiding this comment.
From my pov, this comment adds no value.
| /** | ||
| * Returns label based on content type. | ||
| * | ||
| * @param \Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType $contentType | ||
| * | ||
| * @return string | ||
| * | ||
| * @throws \Ibexa\AdminUi\Exception\InvalidArgumentException | ||
| */ |
There was a problem hiding this comment.
| /** | |
| * Returns label based on content type. | |
| * | |
| * @param \Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType $contentType | |
| * | |
| * @return string | |
| * | |
| * @throws \Ibexa\AdminUi\Exception\InvalidArgumentException | |
| */ | |
| /** | |
| * @throws \Ibexa\AdminUi\Exception\InvalidArgumentException | |
| */ |
|
@dew326 Will this pull request be taken over by someone from the team? |
|
@mikadamczyk It is a pure php solution, so we should rather look for some backend developer if we want to make progress on that. |
v4.6Added possibility to change create content button label
Checklist:
@ibexa/engineering).