IBX-8436: Added modal helper #1320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GrabowskiM
requested changes
Aug 8, 2024
lucasOsti
approved these changes
Aug 13, 2024
|
GrabowskiM
requested changes
Oct 7, 2024
| super(config); | ||
|
|
||
| this.suggestionsListNode = config.suggestionsListNode ?? this.container.querySelector('.ibexa-taggify__suggestions'); | ||
| this.token = config.token ?? doc.querySelector('meta[name="CSRF-Token"]').content; |
There was a problem hiding this comment.
We have currently helpers for extracting these, so maybe it can be used here?
import { getRestInfo } from '@ibexa-admin-ui/src/bundle/Resources/public/js/scripts/helpers/context.helper';
...
const { siteaccess, token } = getRestInfo()
| return; | ||
| } | ||
|
|
||
| if (this.inputNode.value.length > 3) { |
There was a problem hiding this comment.
Put 3 to some const at the begininng to remove this magic number, I guess that's min number of characters needed to perform search?
| const tag = div.querySelector('.ibexa-taggify__list-tag'); | ||
|
|
||
| this.attachEventsToTag(tag, value); | ||
|
|
There was a problem hiding this comment.
I think these empty lines are unnecessary here? (31, 33, 35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: