IBX-3456 Collapse all button support #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OstafinL
requested changes
Nov 18, 2024
GrabowskiM
requested changes
Nov 20, 2024
albozek
commented
Dec 11, 2024
| @@ -0,0 +1,37 @@ | |||
| .ibexa-multi-collapse { | |||
There was a problem hiding this comment.
Moved styles from product-catalog. Based on previous review comment let me know if I still should change class name to ibexa-pc-...
There was a problem hiding this comment.
if those styles are moved from PC where will be a base twig template for a multi-collapse feature?
There was a problem hiding this comment.
Discussed: There is no base twig template due to its too general purpose
tischsoic
reviewed
Dec 11, 2024
albozek
force-pushed
the
IBX-3456-attribute-groups
branch
2 times, most recently
from
1228b09 to
c8db495
Compare
dew326
requested changes
Dec 13, 2024
dew326
approved these changes
Dec 19, 2024
OstafinL
requested changes
Dec 20, 2024
ciastektk
requested changes
Jan 7, 2025
albozek
force-pushed
the
IBX-3456-attribute-groups
branch
from
baed467 to
349a81f
Compare
ciastektk
approved these changes
Jan 13, 2025
...bundle/Resources/views/themes/admin/ui/component/collapse_all_btn/collapse_all_btn.html.twig
Outdated
Show resolved
Hide resolved
KamilSznajdrowicz
requested changes
Jan 24, 2025
albozek
force-pushed
the
IBX-3456-attribute-groups
branch
from
3e31c41 to
300f6d2
Compare
|
KamilSznajdrowicz
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
QA Approved on commerce 4.6.x-dev
Regression with improved behat tests: ibexa/commerce#1172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: