Removed duplicated classes in form_fields.html.twig #853
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| {% if errors|length > 0 %}{% set wrapper_class = (wrapper_class|default('') ~ ' is-invalid')|trim %}{% endif %} | ||
|
|
||
| {% set label_attr = label_attr|merge({'class': (label_attr.class|default('') ~ ' ibexa-label ibexa-data-source__label ibexa-data-source__label')|trim}) %} | ||
| {% set label_wrapper_attr = label_wrapper_attr|default({})|merge({'class': (label_wrapper_attr.class|default('') ~ ' ibexa-data-source__label-wrapper ibexa-data-source__label-wrapper')|trim}) %} | ||
| {% set label_attr = label_attr|merge({'class': (label_attr.class|default('') ~ ' ibexa-label ibexa-data-source__label')|trim}) %} |
There was a problem hiding this comment.
I'm not sure whether we should delete these duplicates. When we try to trace back where they come from we can see that first they were duplicated to have both ibexa- and ez-.
- c5cb76b#diff-3776f7fe593a6a85de0c62980e813efe1256ea7398646bff8c34a16ad83d91aaR45
- and then
ez-was changed toibexa-in this PR probably by a mistake:
a4bdc57#diff-3776f7fe593a6a85de0c62980e813efe1256ea7398646bff8c34a16ad83d91aaR47
So probably we should revert duplicates to ez- to revert changes from 2nd PR? But maybe we no longer want to have ez-, especially given we have already version 4.5?
| {% set label_attr = label_attr|merge({'class': (label_attr.class|default('') ~ ' ibexa-label ibexa-data-source__label')|trim}) %} | |
| {% if required %}{% set wrapper_class = (wrapper_class ~ ' ibexa-data-source__field--required ez-data-source__field--required')|trim %}{% endif %} |
There was a problem hiding this comment.
As main branch currently points to 5.0 we can safely forget about ez- counterpart. @tischsoic Could you please take over this PR ?
|
@tischsoic Will you take over this PR? Also, rabese is needed here |
In form_fields.html.twig there are some classes duplicated. Is it necessary to have duplicity in these classes?
Checklist:
$ composer fix-cs)