Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Refactored various unit tests to make them DRY #408

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[Tests] Refactored various unit tests to make them DRY #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6a8c3be
[Tests] Fixed code duplication in Content & Location handler tests
alongosz Jun 20, 2024
1c1c2cd
[Tests] Refactored redundant code in RejectExplicitFrontControllerReq…
alongosz Jun 22, 2024
490a27b
[Tests] Improved quality of Base Repository service mock tests
alongosz Jul 15, 2024
b435a35
[Tests] Refactored ContentTest to drop redundancy
alongosz Jul 15, 2024
c653f85
[Tests] Refactored PermissionsCriterionHandlerTest to rely on base pe…
alongosz Jul 15, 2024
aa9e8de
[Tests] Aligned RelationProcessorTest with Base changes
alongosz Jul 15, 2024
ad35b08
[Tests] Aligned RoleTest with Base changes
alongosz Jul 15, 2024
dd8c8fb
[Tests] Aligned PermissionTest with Base changes
alongosz Jul 15, 2024
3daa761
[PHPStan] Aligned baseline with the changes
alongosz Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 0 additions & 155 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24605,16 +24605,6 @@ parameters:
count: 1
path: tests/bundle/Core/EventListener/OriginalRequestListenerTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\EventListener\\\\RejectExplicitFrontControllerRequestsListenerTest\\:\\:prohibitedRequestDataProvider\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: tests/bundle/Core/EventListener/RejectExplicitFrontControllerRequestsListenerTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\EventListener\\\\RejectExplicitFrontControllerRequestsListenerTest\\:\\:validRequestDataProvider\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: tests/bundle/Core/EventListener/RejectExplicitFrontControllerRequestsListenerTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Bundle\\\\Core\\\\EventListener\\\\RequestEventListenerTest\\:\\:testOnKernelRequestForward\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -56670,76 +56660,11 @@ parameters:
count: 1
path: tests/lib/Repository/Permission/PermissionCriterionResolverTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:getEventDispatcher\\(\\) should return PHPUnit\\\\Framework\\\\MockObject\\\\MockObject&Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface but returns Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:getRelationProcessorMock\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:getRepository\\(\\) has parameter \\$serviceSettings with no value type specified in iterable type array\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Parameter \\#1 \\$className of method PHPUnit\\\\Framework\\\\TestCase\\:\\:getMockBuilder\\(\\) expects class\\-string\\<mixed\\>, string given\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Parameter \\#2 \\$searchHandler of class Ibexa\\\\Core\\\\Repository\\\\Repository constructor expects Ibexa\\\\Contracts\\\\Core\\\\Search\\\\Handler, PHPUnit\\\\Framework\\\\MockObject\\\\MockObject given\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$contentDomainMapperMock \\(Ibexa\\\\Core\\\\Repository\\\\Mapper\\\\ContentDomainMapper&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$contentTypeDomainMapperMock \\(Ibexa\\\\Core\\\\Repository\\\\Mapper\\\\ContentTypeDomainMapper&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$fieldTypeRegistryMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$fieldTypeServiceMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$permissionServiceMock \\(Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\PermissionService&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$persistenceMock \\(Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Handler&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$repositoryMock \\(Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Repository&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\Base\\:\\:\\$thumbnailStrategyMock \\(Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Strategy\\\\ContentThumbnail\\\\ThumbnailStrategy&PHPUnit\\\\Framework\\\\MockObject\\\\MockObject\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Unable to resolve the template type T in call to method PHPUnit\\\\Framework\\\\TestCase\\:\\:getMockBuilder\\(\\)$#"
count: 1
path: tests/lib/Repository/Service/Mock/Base.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\BookmarkTest\\:\\:createBookmarkService\\(\\) has parameter \\$methods with no value type specified in iterable type array\\.$#"
count: 1
Expand Down Expand Up @@ -57485,41 +57410,11 @@ parameters:
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfo\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfoById\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfoByIdAndVersionNumber\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfoByIdNonPublishedVersion\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfoByIdPublishedVersion\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfoByIdThrowsNotFoundException\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testLoadVersionInfoByIdThrowsUnauthorizedExceptionNonPublishedVersion\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:testUpdateContentNonRedundantFieldSet1\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -57735,11 +57630,6 @@ parameters:
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^PHPDoc tag @var for property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:\\$nameSchemaServiceMock with type PHPUnit\\\\Framework\\\\MockObject\\\\MockObject is not subtype of native type Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\NameSchema\\\\NameSchemaServiceInterface\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Parameter \\#1 \\$languageHandlerMock of method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:loadByLanguageCodeMock\\(\\) expects PHPUnit\\\\Framework\\\\MockObject\\\\MockObject, Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Language\\\\Handler given\\.$#"
count: 1
Expand Down Expand Up @@ -57770,11 +57660,6 @@ parameters:
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\ContentTest\\:\\:\\$relationProcessorMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/ContentTest.php

-
message: "#^Call to an undefined method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\User\\\\Handler\\:\\:expects\\(\\)\\.$#"
count: 11
Expand All @@ -57790,21 +57675,11 @@ parameters:
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:getPermissionResolverMock\\(\\) has parameter \\$methods with no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:getPermissionSetsMock\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:getUserReferenceMock\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:providerForTestCanUserComplex\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
Expand Down Expand Up @@ -57985,11 +57860,6 @@ parameters:
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:testSetAndGetCurrentUserReference\\(\\) has no return type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^PHPDoc tag @var has invalid value \\(\\$policy \\\\Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\User\\\\Policy\\)\\: Unexpected token \"\\$policy\", expected type at offset 9$#"
count: 1
Expand Down Expand Up @@ -58020,31 +57890,11 @@ parameters:
count: 3
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:\\$permissionResolverMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:\\$repositoryMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionTest\\:\\:\\$userReferenceMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Variable \\$limitationsPass might not be defined\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:getPermissionResolverMock\\(\\) has parameter \\$methods with no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:mockServices\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -58150,11 +58000,6 @@ parameters:
count: 1
path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php

-
message: "#^Property Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Service\\\\Mock\\\\PermissionsCriterionHandlerTest\\:\\:\\$permissionResolverMock has no type specified\\.$#"
count: 1
path: tests/lib/Repository/Service/Mock/PermissionsCriterionHandlerTest.php

-
message: "#^Call to an undefined method Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\Location\\\\Handler\\:\\:expects\\(\\)\\.$#"
count: 2
Expand Down
Loading
Loading