IBX-9107 Added link to the min.js ibexa tracker file. #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto IBX-9107_added_min_js_tracker # Conflicts: # docs/personalization/tracking_with_ibexa-tracker.md
mnocon
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Thank you for the PR!
I believe people should simply use the minified version and forget about it, right?
I suggest changing the line 44 to cdn.perso.ibexa.co/ibexa-tracker.min.js(as this will actually make them use the minified version).
I would even consider not mentioning the "full" version at all - I don't think it's needed. What do you think?
Comment on lines
25
to
28
| `<YOUR_MANDATOR_ID>` with the customer ID, `<PAGE_ID>` with the page/item identifier. | ||
| `<USER_ID>` - empty string for cookie based anonymous user or replaced with the value generated | ||
| by your user identifier system for logged-in user. In case user activity should not be tracked, | ||
| 'not_defined' value should be used to still have an event stored without link to the user. |
There was a problem hiding this comment.
Suggested change
| `<YOUR_MANDATOR_ID>` with the customer ID, `<PAGE_ID>` with the page/item identifier. | |
| `<USER_ID>` - empty string for cookie based anonymous user or replaced with the value generated | |
| by your user identifier system for logged-in user. In case user activity should not be tracked, | |
| 'not_defined' value should be used to still have an event stored without link to the user. | |
| - `<YOUR_MANDATOR_ID>` with the customer ID | |
| - `<CONTENT_TYPE_ID>` with the Content Type ID | |
| - `<CONTENT_ID>` with the content item ID | |
| - `<USER_ID>` with an empty string for cookie based anonymous user or replaced with the value generated by your user identifier system for logged-in user. In case user activity should not be tracked, 'not_defined' value should be used to still have an event stored without a link to the user. |
- I think a list makes it more readable
- The PAGE_ID placeholder doesn't exist anymore, but there's CONTENT_ID and CONTENT_TYPE_ID - can you please check if my suggestion makes sense?
- Please also add a
:after replace (I cannot add it through GitHub suggsetions)
There was a problem hiding this comment.
Chaged according to suggestion.
About keep only minified version, I think it will be good for debug purpose to have the original file. It could help partners easy undersdtand how tracking working.
juskora
reviewed
Oct 18, 2024
Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
mnocon
pushed a commit
that referenced
this pull request
Oct 18, 2024
* IBX-9107 Added link to the min.js ibexa tracker file. * IBX-9107 Added link to the min.js ibexa tracker file. * IBX-9107 Added link to the min.js ibexa tracker file. * IBX-9107 Added more details about user * IBX-9107 Fixed spaces. * IBX-9107 Updated not defined user details. * IBX-9107 Changed after PR comments. * Update docs/personalization/tracking_with_ibexa-tracker.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * IBX-9107 Changed url in example --------- Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
mnocon
pushed a commit
that referenced
this pull request
Nov 8, 2024
* IBX-9107 Added link to the min.js ibexa tracker file. * IBX-9107 Added link to the min.js ibexa tracker file. * IBX-9107 Added link to the min.js ibexa tracker file. * IBX-9107 Added more details about user * IBX-9107 Fixed spaces. * IBX-9107 Updated not defined user details. * IBX-9107 Changed after PR comments. * Update docs/personalization/tracking_with_ibexa-tracker.md Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com> * IBX-9107 Changed url in example --------- Co-authored-by: Justyna Koralewicz <79849375+juskora@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added link to the ibexa tracker minified javascript file.
Added more details about userId
Checklist