-
Notifications
You must be signed in to change notification settings - Fork 85
AI: Extending follow-up #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
AI: Extending follow-up #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code_samples/ai_actions/src/Command/AddMissingAltTextCommand.php
Outdated
Show resolved
Hide resolved
code_samples/ai_actions/src/Command/AddMissingAltTextCommand.php
Outdated
Show resolved
Hide resolved
adriendupuis
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks globaly good. I would change when/how the image URI correctness is checked.
Preview of modified Markdown: |
code_samples/ change report
|
@adriendupuis image correctness improved in 4c323b9 (PHPStan is passing locally with these changes) |
adriendupuis
approved these changes
Feb 18, 2025
mnocon
added a commit
that referenced
this pull request
Feb 18, 2025
* AI: Review follow-up * Applied review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target: 4.6, master
Things done:
Previews: