Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed composer.json file #44

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Fixed composer.json file #44

merged 2 commits into from
Mar 21, 2024

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
JIRA issue N/A
Type Improvement
Target version 4.6
BC breaks no
Doc needed no

The section autoload-dev was duplicated.

Key autoload-dev is a duplicate in ./composer.json at line 61

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk requested a review from a team February 8, 2024 09:15
@konradoboza konradoboza requested a review from a team February 8, 2024 09:16
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the actual autoload-dev section while at it? EzSystems entry should be the last one.

@Steveb-p
Copy link
Contributor

Steveb-p commented Feb 8, 2024

Could you fix the actual autoload-dev section while at it? EzSystems entry should be the last one.

In context of tests, class_alias should not be used (since those are not even reachable from outside of the package). So legacy name entry should also be completely removed, not just moved. Along with class_alias calls in tests/ directory.

Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz
Copy link
Member

alongosz commented Feb 8, 2024

Could you fix the actual autoload-dev section while at it? EzSystems entry should be the last one.

In context of tests, class_alias should not be used (since those are not even reachable from outside of the package). So legacy name entry should also be completely removed, not just moved. Along with class_alias calls in tests/ directory.

True, I suggested it but it was dropped based on too much complexity on already too complex rebranding project :-)
We'll drop all class_alias entries in 5.0. But you're right of course it's dead code.

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both current state and Steve's suggestion is fine for me.

@alongosz alongosz requested a review from a team February 8, 2024 10:32
@mikadamczyk mikadamczyk changed the base branch from main to 4.6 March 20, 2024 09:47
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit bee4120 into 4.6 Mar 21, 2024
25 checks passed
@alongosz alongosz deleted the composer-fix branch March 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants