Upstream merge 2024-09-20 #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added line break to improve page formatting
…TimeToScheduledTripTimesMapper.java Co-authored-by: Thomas Gran <t2gran@gmail.com>
also updated descriptions to reflect recent changes to realtime system
arrows now point at correct hierarchical level, but stop short of the specific individual objects when they are referring to instances that are elided from the diagrams
…/npm-vite-vulnerability Update dependency vite to v5.4.6 [SECURITY]
…/debug-ui-dependencies-(non-major) Update Debug UI dependencies (non-major)
…/major-geotools.version Update geotools.version to v32 (major)
…times-colors Add full ISO times and colours to debug UI
…-leg Extra leg when transferring at the same stop
|
For the new "transfer" leg am I right in seeing that it's generating a WALK type leg? Am I supposed to compare the from/to to identify that it's a transfer leg instead of a walking leg? |
|
All transfer legs are walk legs. For anything else we would need a new schema, which is a super breaking change. |
|
The distance is also 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to insert an extra leg when transferring at the exact same stop: opentripplanner#5984
You need to enable the feature flag
ExtraTransferLegOnSameStop.It also fixes the parsing of safe_duration_offset but that is likely to change again: opentripplanner#5984
The arrive by fix for Hopelink is not merge upstream yet, so please don't deploy this merge there. Use #223 instead.