refactor: remove base implementation for quantile

ibis-project · Aug 16, 2024 · 3c49c6a · 3c49c6a
1 parent 3cfc344
commit 3c49c6a
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 31 deletions.
diff --git a/ibis/backends/sql/compilers/base.py b/ibis/backends/sql/compilers/base.py
@@ -1054,19 +1054,6 @@ def visit_Max(self, op, *, arg, where):
 
     ### Stats
 
-    def visit_Quantile(self, op, *, arg, quantile, where):
-        suffix = "cont" if op.arg.dtype.is_numeric() else "disc"
-        funcname = f"percentile_{suffix}"
-        expr = sge.WithinGroup(
-            this=self.f[funcname](quantile),
-            expression=sge.Order(expressions=[sge.Ordered(this=arg)]),
-        )
-        if where is not None:
-            expr = sge.Filter(this=expr, expression=sge.Where(this=where))
-        return expr
-
-    visit_MultiQuantile = visit_Quantile
-
     def visit_VarianceStandardDevCovariance(self, op, *, how, where, **kw):
         hows = {"sample": "samp", "pop": "pop"}
         funcs = {

diff --git a/ibis/backends/sql/compilers/bigquery/__init__.py b/ibis/backends/sql/compilers/bigquery/__init__.py
@@ -120,8 +120,6 @@ class BigQueryCompiler(SQLGlotCompiler):
         ops.ExtractUserInfo,
         ops.FindInSet,
         ops.Median,
-        ops.Quantile,
-        ops.MultiQuantile,
         ops.RegexSplit,
         ops.RowID,
         ops.TimestampDiff,

diff --git a/ibis/backends/sql/compilers/datafusion.py b/ibis/backends/sql/compilers/datafusion.py
@@ -40,8 +40,6 @@ class DataFusionCompiler(SQLGlotCompiler):
         ops.Greatest,
         ops.IntervalFromInteger,
         ops.Least,
-        ops.MultiQuantile,
-        ops.Quantile,
         ops.RowID,
         ops.Strftime,
         ops.TimeDelta,

diff --git a/ibis/backends/sql/compilers/druid.py b/ibis/backends/sql/compilers/druid.py
@@ -47,8 +47,6 @@ class DruidCompiler(SQLGlotCompiler):
         ops.IsInf,
         ops.Levenshtein,
         ops.Median,
-        ops.MultiQuantile,
-        ops.Quantile,
         ops.RandomUUID,
         ops.RegexReplace,
         ops.RegexSplit,

diff --git a/ibis/backends/sql/compilers/flink.py b/ibis/backends/sql/compilers/flink.py
@@ -83,9 +83,7 @@ class FlinkCompiler(SQLGlotCompiler):
         ops.IsNan,
         ops.Levenshtein,
         ops.Median,
-        ops.MultiQuantile,
         ops.NthValue,
-        ops.Quantile,
         ops.ReductionVectorizedUDF,
         ops.RegexSplit,
         ops.RowID,

diff --git a/ibis/backends/sql/compilers/impala.py b/ibis/backends/sql/compilers/impala.py
@@ -34,9 +34,7 @@ class ImpalaCompiler(SQLGlotCompiler):
         ops.Levenshtein,
         ops.Map,
         ops.Median,
-        ops.MultiQuantile,
         ops.NthValue,
-        ops.Quantile,
         ops.RegexSplit,
         ops.RowID,
         ops.StringSplit,

diff --git a/ibis/backends/sql/compilers/mssql.py b/ibis/backends/sql/compilers/mssql.py
@@ -99,9 +99,7 @@ class MSSQLCompiler(SQLGlotCompiler):
         ops.Map,
         ops.Median,
         ops.Mode,
-        ops.MultiQuantile,
         ops.NthValue,
-        ops.Quantile,
         ops.RegexExtract,
         ops.RegexReplace,
         ops.RegexSearch,

diff --git a/ibis/backends/sql/compilers/mysql.py b/ibis/backends/sql/compilers/mysql.py
@@ -74,8 +74,6 @@ def POS_INF(self):
         ops.Levenshtein,
         ops.Median,
         ops.Mode,
-        ops.MultiQuantile,
-        ops.Quantile,
         ops.RegexReplace,
         ops.RegexSplit,
         ops.RowID,

diff --git a/ibis/backends/sql/compilers/postgres.py b/ibis/backends/sql/compilers/postgres.py
@@ -226,6 +226,19 @@ def visit_CountDistinctStar(self, op, *, where, arg):
         )
         return self.agg.count(sge.Distinct(expressions=[row]), where=where)
 
+    def visit_Quantile(self, op, *, arg, quantile, where):
+        suffix = "cont" if op.arg.dtype.is_numeric() else "disc"
+        funcname = f"percentile_{suffix}"
+        expr = sge.WithinGroup(
+            this=self.f[funcname](quantile),
+            expression=sge.Order(expressions=[sge.Ordered(this=arg)]),
+        )
+        if where is not None:
+            expr = sge.Filter(this=expr, expression=sge.Where(this=where))
+        return expr
+
+    visit_MultiQuantile = visit_Quantile
+
     def visit_Correlation(self, op, *, left, right, how, where):
         if how == "sample":
             raise com.UnsupportedOperationError(

diff --git a/ibis/backends/sql/compilers/sqlite.py b/ibis/backends/sql/compilers/sqlite.py
@@ -38,8 +38,6 @@ class SQLiteCompiler(SQLGlotCompiler):
         ops.IsInf,
         ops.Covariance,
         ops.Correlation,
-        ops.Quantile,
-        ops.MultiQuantile,
         ops.Median,
         ops.ApproxMedian,
         ops.Array,

diff --git a/ibis/backends/sql/compilers/trino.py b/ibis/backends/sql/compilers/trino.py
@@ -46,8 +46,6 @@ class TrinoCompiler(SQLGlotCompiler):
     NEG_INF = -POS_INF
 
     UNSUPPORTED_OPS = (
-        ops.Quantile,
-        ops.MultiQuantile,
         ops.Median,
         ops.RowID,
         ops.TimestampBucket,