Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): apply casting logic for json output to scalars #10202

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 24, 2024

Fixes the failing Snowflake test on main.

@cpcloud cpcloud added this to the 10.0 milestone Sep 24, 2024
@cpcloud cpcloud added ci Continuous Integration issues or PRs datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) snowflake The Snowflake backend labels Sep 24, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Sep 24, 2024

Snowflake is passing:

…/ibis on  snowflake-cast-list-fix is 📦 v9.5.0 via 🐍 v3.12.5 via ❄️   impure (ibis-3.12.5-env) took 3s
❯ pytest -m snowflake -n 8 --dist loadgroup --snapshot-update -q --maxfail=30
bringing up nodes...
....s..................................x...........x....xx...........................x.......................................x....................................xxxxxxxx.xxxxx.......x....x. [  9%]
................x..................................x....x......x.x..xx.....x..xx.............x.......x.x...x.x.xx.............xx......xx..x...x.....x.....x.x...................x.x...x...xxx. [ 19%]
....x.x..............x.......x..........x..........x...........xx.x.x...............x...x..............xx......x........x.x...........x.............................x.......x.....x.......x.x. [ 28%]
..xx....................................x.......s...........x.............x......x....x......................................x.x..........x...............x................................... [ 38%]
..........................x..x....................x..............................................................x.............................s.................s.....s...................... [ 47%]
...................................................................x.................x....x..xx.xx....xx.xxxx..xxx..xx.xxx......xxxxxxx.x..xx.x...x.x.x......xxx..x.x.xxxx.x.xxx.x.x..x..x..xx [ 57%]
x.xx.x..xx.....x.xx...x..........................x....xx.....x...xx.......................xx...x..........................x..............x.........x.........x.........x......x...........x.x. [ 67%]
...................x...x.............xx...x.s...............x........x.....xxx...x..............x.xx..x.x............xx..xxxxxxxxx.x..x..x..xx...........x.............xx.......x............. [ 76%]
...........x.....x..............x...........x....................................................x.................x..x....x...xx.xx............s........x...........x.......x..............x. [ 86%]
............................................................s...............................................................................................................s................. [ 95%]
...........................x.................................s.........x..x...x.x                                                                                                              [100%]
1742 passed, 10 skipped, 229 xfailed in 254.21s (0:04:14)

@cpcloud cpcloud merged commit 91764d3 into ibis-project:main Sep 24, 2024
82 checks passed
@cpcloud cpcloud deleted the snowflake-cast-list-fix branch September 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant