Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fixtures): ensure that most connections are cleaned up when the session ends #10693

Merged
merged 3 commits into from
Jan 22, 2025
Merged

test(fixtures): ensure that most connections are cleaned up when the session ends #10693

merged 3 commits into from
Jan 22, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 21, 2025

Clean up test sessions using disconnect, to avoid leaking resources, and resource warnings

@cpcloud cpcloud added this to the 10.0 milestone Jan 21, 2025
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests labels Jan 21, 2025
@github-actions github-actions bot added impala The Apache Impala backend postgres The PostgreSQL backend sqlite The SQLite backend clickhouse The ClickHouse backend mysql The MySQL backend pyspark The Apache PySpark backend datafusion The Apache DataFusion backend duckdb The DuckDB backend polars The polars backend snowflake The Snowflake backend mssql The Microsoft SQL Server backend trino The Trino backend oracle The Oracle backend risingwave The RisingWave backend labels Jan 21, 2025
@cpcloud cpcloud force-pushed the cleanup-sessions-in-tests branch from 395bcb3 to 1efb9e6 Compare January 21, 2025 13:26
@cpcloud cpcloud force-pushed the cleanup-sessions-in-tests branch from 1efb9e6 to 3505f77 Compare January 21, 2025 15:26
@cpcloud cpcloud merged commit b9bd2a8 into ibis-project:main Jan 22, 2025
87 checks passed
@cpcloud cpcloud deleted the cleanup-sessions-in-tests branch January 22, 2025 12:15
cpcloud added a commit to cpcloud/ibis that referenced this pull request Jan 23, 2025
@cpcloud
test(fixtures): ensure that most connections are cleaned up when the …
07d13cd 
…session ends (ibis-project#10693)
cpcloud added a commit to cpcloud/ibis that referenced this pull request Jan 24, 2025
@cpcloud
revert: test(fixtures): ensure that most connections are cleaned up w…
f76cbe1 
…hen the session ends (ibis-project#10693)

This reverts commit b9bd2a8.
cpcloud added a commit that referenced this pull request Jan 24, 2025
@cpcloud
revert: test(fixtures): ensure that most connections are cleaned up w…
470e6fd 
…hen the session ends (#10693) (#10717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clickhouse The ClickHouse backend datafusion The Apache DataFusion backend duckdb The DuckDB backend impala The Apache Impala backend mssql The Microsoft SQL Server backend mysql The MySQL backend oracle The Oracle backend polars The polars backend postgres The PostgreSQL backend pyspark The Apache PySpark backend refactor Issues or PRs related to refactoring the codebase risingwave The RisingWave backend snowflake The Snowflake backend sqlite The SQLite backend tests Issues or PRs related to tests trino The Trino backend
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud