Error log : SyncEventsFailure #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Event Failure error log creation happens when the data watcher cannot be created for a path in immediate sync. Since the error log creation is within an exception, it is spawned. When the above logic is added, it fails some Unit Test cases. On debugging observed the below flow causing the failure: The ctx is stopped to exit from the loop on watching the data paths. This will fail the syncData spawning throwing an error. Before, this error was caught in exception and gracefully exited. But now in addition to this, an error log is being created for which we need ctx. This causes a runtime error resulting in UT failure. To solve this, a check is added for `ctx.stop_requested` before spawning error log creation. Change-Id: Ie7a98e933003a095dffd414826072d8866e61276 Signed-off-by: Riya Sabu <riya.sabu461@gmail.com>
riya461
changed the title
RameshIyyar
reviewed
Jan 19, 2026
| dataSyncCfg.getSyncTypeInStr(); | ||
| if (!_ctx.stop_requested()) | ||
| { | ||
| _ctx.spawn(_extDataIfaces->createErrorLog( |
Collaborator
There was a problem hiding this comment.
I think we discussed to use co_await with scope_fail, right?
| "{ERROR}", | ||
| "PATH", dataSyncCfg._path, "ERROR", e.what()); | ||
|
|
||
| // Error log if fails to create watcher for a |
Collaborator
There was a problem hiding this comment.
I feel, these comment is unnecessary. The function name itself explains it.
| // Error log if fails to create watcher for a | ||
| // file/directory. | ||
| ext_data::AdditionalData additionalDetails = { | ||
| {"DS_Sync_Event_Path", dataSyncCfg._path.string()}, |
Collaborator
There was a problem hiding this comment.
DS_Sync_Event_Path
DS_Sync_Path?
| // file/directory. | ||
| ext_data::AdditionalData additionalDetails = { | ||
| {"DS_Sync_Event_Path", dataSyncCfg._path.string()}, | ||
| {"DS_Sync_Event_Msg", "Failed to create watcher for the path"}}; |
| ext_data::AdditionalData additionalDetails = { | ||
| {"DS_Sync_Event_Path", dataSyncCfg._path.string()}, | ||
| {"DS_Sync_Event_Msg", "Failed to create watcher for the path"}}; | ||
| additionalDetails["DS_Sync_Event_Type"] = |
Collaborator
There was a problem hiding this comment.
DS_Sync_Event_Type
DS_Sync_Type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Event Failure error log creation happens when
the data watcher cannot be created for a path in immediate sync.
Since the error log creation is within an exception, it is spawned. When the above logic is added, it fails some Unit Test cases.
On debugging observed the below flow causing the failure: The ctx is stopped to exit from the loop on watching the data paths. This will fail the syncData spawning throwing an error.
Before, this error was caught in exception and gracefully exited. But now in addition to this, an error log is being created for which we need ctx.
This causes a runtime error resulting in UT failure.
To solve this, a check is added for
ctx.stop_requestedbefore spawning error log creation.Change-Id: Ie7a98e933003a095dffd414826072d8866e61276