-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor check valve with spline interpolation #1938
Conversation
@mwetter This is ready. Can you suggest a name for an external review? |
This sentence is wrong as it refers to a velocity and not a flow rate. It is also not clear what a value would be at other flow rates, hence I deleted it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineGautier : I am not sure we approached this the right way, in part because I don't understand your implementation (see inline comment).
Wouldn't it be simpler if we were to compute
@mwetter With 11097a8 the function calls are now included in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineGautier : Thanks for the changes. This addresses my concerns that we discussed on Friday.
This addresses #1937.