Skip to content

Commit

Permalink
Merge pull request #609 from ibpsa/issue601_typoDesDoc
Browse files Browse the repository at this point in the history
Closes #601
  • Loading branch information
dhblum authored Jan 27, 2024
2 parents 3c04cc0 + 494bc9f commit 8c733d5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/design/source/testcasedev.rst
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ The second function is to export a wrapper FMU that utilizes the signal exchange

4. Add one output for every Read block found named :code:`<block_instance_path>_y`. Assign :code:`<block_instance_path>_y` the unit, descriptions, min/max, and other signal attribute data specified by the Read block.

5. For Overwrite blocks, connect :code:`<block_instance_path>_u` to :code:`<block.instance.path>.u`, :code:`<block_instance_path>_activate` to :code:`<block.instance.path>.activate`, and :code:`<block_instance_path>_y` to :code:`<block.instance.path>.y`.
5. For Overwrite blocks, connect :code:`<block_instance_path>_u` to :code:`<block.instance.path>.uExt.y`, :code:`<block_instance_path>_activate` to :code:`<block.instance.path>.activate.y`, and :code:`<block_instance_path>_y` to :code:`<block.instance.path>.y`.

6. For Read blocks, connect :code:`<block_insance_path>_y` to :code:`<block.instance.path>.y`.

Expand Down
1 change: 1 addition & 0 deletions releasenotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Released on xx/xx/xxxx.
- Specify the Python version (3.7) used for building the wrapper to execute the example JavaScript controllers in the unit test. This is for [#594](https://github.com/ibpsa/project1-boptest/issues/594).
- Allow simulations and forecast to work across the end of the year to the next year. This is for [#239](https://github.com/ibpsa/project1-boptest/issues/239).
- Pin base Docker image to ``linux/x86_64`` platform. This is for [#608](https://github.com/ibpsa/project1-boptest/issues/608).
- Correct typo in design documentation about connecting inputs to overwrite blocks in wrapper model. This is for [#601](https://github.com/ibpsa/project1-boptest/issues/601).

## BOPTEST v0.5.0

Expand Down
10 changes: 5 additions & 5 deletions testing/utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -749,35 +749,35 @@ def test_invalid_forecast_parameters(self):
'horizon': 'foo',
'interval': 300}
payload = requests.put('{0}/forecast'.format(self.url),
data=forecast_parameters_ref)
json=forecast_parameters_ref)
self.compare_error_code(payload, "Invalid non-numeric horizon in forecast request did not return 400 message.")
# Try setting non-numeric interval
forecast_parameters_ref = {'point_names':forecast_points,
'horizon': 3600,
'interval': 'foo'}
payload = requests.put('{0}/forecast'.format(self.url),
data=forecast_parameters_ref)
json=forecast_parameters_ref)
self.compare_error_code(payload, "Invalid non-numeric interval in forecast request did not return 400 message.")
# Try setting negative horizon
forecast_parameters_ref = {'point_names':forecast_points,
'horizon': -3600,
'interval': 300}
payload = requests.put('{0}/forecast'.format(self.url),
data=forecast_parameters_ref)
json=forecast_parameters_ref)
self.compare_error_code(payload, "Invalid negative horizon in forecast request did not return 400 message.")
# Try setting negative interval
forecast_parameters_ref = {'point_names':forecast_points,
'horizon': 3600,
'interval': -300}
payload = requests.put('{0}/forecast'.format(self.url),
data=forecast_parameters_ref)
json=forecast_parameters_ref)
self.compare_error_code(payload, "Invalid negative interval in forecast request did not return 400 message.")
# Try setting invalid point name
forecast_parameters_ref = {'point_names':['foo'],
'horizon': 3600,
'interval': 300}
payload = requests.put('{0}/forecast'.format(self.url),
data=forecast_parameters_ref)
json=forecast_parameters_ref)
self.compare_error_code(payload, "Invalid point_names in forecast request did not return 400 message.")

def test_invalid_scenario(self):
Expand Down

0 comments on commit 8c733d5

Please sign in to comment.