Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ReportBuilder to functional #542

Conversation

mshriver
Copy link
Contributor

Pretty straightforward migration, dropped one unused state item for total pages.

Had to use callback functions for the useEffect hooks

@mshriver mshriver added enhancement New feature or request frontend labels Jan 22, 2025
@mshriver mshriver requested a review from Fynardo January 22, 2025 14:48
@mshriver mshriver force-pushed the reportbuild-react-functional branch from 020b8de to bb037ad Compare January 22, 2025 15:02
@mshriver mshriver marked this pull request as draft January 22, 2025 15:06
@mshriver mshriver force-pushed the reportbuild-react-functional branch from bb037ad to 57e00ec Compare January 22, 2025 15:07
Pretty straightforward migration, dropped one unused state item for
total pages.

Had to use callback functions for the useEffect hookst
@mshriver mshriver force-pushed the reportbuild-react-functional branch from 57e00ec to 803562a Compare January 22, 2025 19:44
@mshriver mshriver marked this pull request as ready for review January 22, 2025 19:46
@mshriver mshriver merged commit 21e7569 into ibutsu:feature-react-functional Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant