Skip to content

Convert UserDropdown to Functional #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Fynardo
Copy link
Collaborator

@Fynardo Fynardo commented Jan 22, 2025

No description provided.

@Fynardo Fynardo marked this pull request as draft January 22, 2025 17:02
@mshriver
Copy link
Contributor

This should follow #540 and will need to be rebased.

@Fynardo Fynardo force-pushed the user-dropdown-3305 branch from af77a35 to dad0b6a Compare January 23, 2025 09:53
@Fynardo Fynardo marked this pull request as ready for review January 23, 2025 11:46
Copy link
Contributor

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for some code golf, not necessary. Talked to @Fynardo about local testing results.

@mshriver mshriver merged commit 0d7fcd1 into ibutsu:feature-react-functional Jan 23, 2025
9 checks passed
mshriver pushed a commit that referenced this pull request Apr 24, 2025
* Convert user-dropdown to functional

* address linting issues
mshriver pushed a commit that referenced this pull request Apr 24, 2025
* Convert user-dropdown to functional

* address linting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants