Refactor ParamDropdown and WidgetHeader #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
widgetcomponents-3331
branch
6 times, most recently
from
ed7df0c to
47052cc
Compare
new file for WidgetHeader
mshriver
force-pushed
the
widgetcomponents-3331
branch
from
47052cc to
8dc5ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated
ParamDropdownandWidgetHeadercomponents into their own files.Simplified WidgetHeader, no need for both
descriptionandtooltipparameters, or theshowDescriptionparameter which was never in use.Small updates to FilterHeatmap to consistently pass actions as a list.